-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Service Wiring / Concurrency pt 1 [ALT/Middleware] #2440
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dave Lee <[email protected]>
Signed-off-by: Dave Lee <[email protected]>
…xtractor based middlewares for reuse Signed-off-by: Dave Lee <[email protected]>
✅ Deploy Preview for localai canceled.
|
dave-gray101
changed the title
DRAFT
refactor: Service Wiring / Concurrency pt 1 [ALT/Middleware]
May 29, 2024
Signed-off-by: Dave Lee <[email protected]>
Signed-off-by: Dave Lee <[email protected]>
…lAI into backport-ctx-locals-mw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an ALTERNATIVE to #2392 . See https://github.com/dave-gray101/LocalAI/pull/1/files for a diff.
core/http/ctx
we can skip over 2392 and go straight to 2440. Normally, I'd say this is a pretty minor concern, but given that these PRs have been difficult to find safe merge windows for, I'm concerned that it could cause more work for us to leave it be.core/http/endpoints/openai
folder anyway.This PR should not be set to auto merge right now - I want to manually check that diff before merging the final versions.
This PR is the start of transitioning our core services to the core/application.go \ core/startup model.
In order to keep things reviewable, this PR will have a limited scope - rather than moving everything at once, my goal is to select services that are covered by existing tests for the detection of regressions. Therefore, this PR contains the following components:
http/middleware
, migrating request object handling outside the endpoints themselves.